Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114053: Fix bad interaction of PEP 695, PEP 563 and inspect.get_annotations #120270

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 8, 2024

@AlexWaygood
Copy link
Member Author

While working on this PR, I spotted another bug in get_type_hints, which will be fixed in #120272.

@AlexWaygood AlexWaygood marked this pull request as draft June 9, 2024 10:43
@AlexWaygood AlexWaygood marked this pull request as ready for review June 13, 2024 20:50
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 13, 2024 20:51
@AlexWaygood AlexWaygood merged commit 42351c3 into python:main Jun 13, 2024
33 checks passed
@AlexWaygood AlexWaygood deleted the getannotations-nameerror branch June 13, 2024 21:16
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
….get_annotations` (pythonGH-120270)

(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
….get_annotations` (pythonGH-120270)

(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 13, 2024

GH-120474 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 13, 2024

GH-120475 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 13, 2024
AlexWaygood added a commit that referenced this pull request Jun 13, 2024
…t.get_annotations` (GH-120270) (#120475)

gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect.get_annotations` (GH-120270)
(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 13, 2024
…t.get_annotations` (GH-120270) (#120474)

gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect.get_annotations` (GH-120270)
(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants