-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-114053: Fix bad interaction of PEP 695, PEP 563 and inspect.get_annotations
#120270
Merged
AlexWaygood
merged 6 commits into
python:main
from
AlexWaygood:getannotations-nameerror
Jun 13, 2024
Merged
gh-114053: Fix bad interaction of PEP 695, PEP 563 and inspect.get_annotations
#120270
AlexWaygood
merged 6 commits into
python:main
from
AlexWaygood:getannotations-nameerror
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexWaygood
commented
Jun 8, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: typing.get_type_hints fails when passed a class with PEP 695 type parameters and PEP 563 is enabled #114053
….get_annotations`
While working on this PR, I spotted another bug in |
JelleZijlstra
approved these changes
Jun 13, 2024
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2024
….get_annotations` (pythonGH-120270) (cherry picked from commit 42351c3) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2024
….get_annotations` (pythonGH-120270) (cherry picked from commit 42351c3) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
GH-120474 is a backport of this pull request to the 3.13 branch. |
GH-120475 is a backport of this pull request to the 3.12 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
….get_annotations` (python#120270)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
….get_annotations` (python#120270)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
….get_annotations` (python#120270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.