gh-120200: Fix inspect.iscoroutinefunction(inspect) is True corner case
#120214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @sobolevn, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2024
…orner case (pythonGH-120214) (cherry picked from commit 10fb1b8) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-120237 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Jun 7, 2024
…True` corner case (pythonGH-120214) (cherry picked from commit 10fb1b8) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Are we fine with 3.12 and 3.13 backports? I just created them, but haven't merged anything yet. |
|
GH-120239 is a backport of this pull request to the 3.12 branch. |
Yes totally fine. This is just a bug. |
sobolevn
added a commit
that referenced
this pull request
Jun 7, 2024
sobolevn
added a commit
that referenced
this pull request
Jun 7, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @carltongibson as the original author
CC @gvanrossum and @kumaraditya303 as original reviewers
I think that the name change is the somplest fix here. Since this name is protected and undocumented, this should not be a breaking change.
However, what do we care about more? Supporting this corner-case or keeping the old name?
If the former, then I can close this PR.