-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Move inline JavaScript to own file to reduce duplication #119541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My PR added 3.14 in layout.html which conflicts with the change of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes sense and looks good to me! 👍🏼
PR #119607 will fix the doctest. |
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @hugovk, I could not cleanly backport this to
|
…pythonGH-119541) (cherry picked from commit eea26c4) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-119630 is a backport of this pull request to the 3.13 branch. |
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @hugovk, I could not cleanly backport this to
|
I'll include this 3.12 backport in the #120348 backport. |
Follow on from #116966.
Move the language/version switcher JavaScript from the
layout.html
template, which meant it was included in the header of every page, and into its own JavaScript file to reduce duplication.This reduces the size of the entire docs HTML (
Doc/build/html
) from 69.7 MB to 68.2 MB.cc @humitos
📚 Documentation preview 📚: https://cpython-previews--119541.org.readthedocs.build/