Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119469: Fix _pyrepl reference leaks #119470

Merged
merged 1 commit into from
May 23, 2024
Merged

gh-119469: Fix _pyrepl reference leaks #119470

merged 1 commit into from
May 23, 2024

Conversation

ambv
Copy link
Contributor

@ambv ambv commented May 23, 2024 •
edited by bedevere-app bot
Loading

Co-authored-by: Victor Stinner vstinner@python.org

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 23, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 23, 2024
Closed
@ambv ambv added skip news topic-repl Related to the interactive shell labels May 23, 2024
vstinner
vstinner approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that this change fix the issue:

$ ./python -m test test_pyrepl -u all -R 3:3 
(...)
Result: SUCCESS

lysnikolaou
lysnikolaou approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou added the needs backport to 3.13 bugs and security fixes label May 23, 2024
@ambv ambv merged commit 6e012ce into python:main May 23, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@ambv @miss-islington
pythongh-119469: Fix _pyrepl reference leaks (pythonGH-119470)
f283166 
(cherry picked from commit 6e012ce)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented May 23, 2024

GH-119471 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 23, 2024
@ambv ambv deleted the pyrepl-leak branch May 23, 2024 17:28
ambv added a commit that referenced this pull request May 23, 2024
@miss-islington @ambv
[3.13] gh-119469: Fix _pyrepl reference leaks (GH-119470) (#119471)
8fd8cc5 
(cherry picked from commit 6e012ce)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ambv @estyxx
pythongh-119469: Fix _pyrepl reference leaks (python#119470)
43e6a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambv @vstinner @lysnikolaou