Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118911: Trailing whitespace in a block shouldn't prevent the user from terminating the code block #119355

Merged
merged 8 commits into from
May 22, 2024
Merged

gh-118911: Trailing whitespace in a block shouldn't prevent the user from terminating the code block #119355

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
77ca92a
gh-118911: Trailing whitespace in a block shouldnt prevent the user f…
aelsayed95 May 21, 2024
edbf327
📜🤖 Added by blurb_it.
blurb-it[bot] May 21, 2024
4996c5e
for clarity
aelsayed95 May 21, 2024
6ee25da
Merge branch 'fix_issue_118911' of github.com:aelsayed95/cpython into…
aelsayed95 May 21, 2024
6c0682b
lint
aelsayed95 May 21, 2024
4e62b96
reword NEWS.d
aelsayed95 May 21, 2024
71d1bcb
Merge branch 'main' into gh-119355
ambv May 22, 2024
27ad76c
Fix ReST syntax in blurb, reword a bit
ambv May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix ReST syntax in blurb, reword a bit
  • Loading branch information
@ambv
ambv committed May 22, 2024
commit 27ad76cb9d6827686b331126f1e9eb9713916e9e
7 changes: 5 additions & 2 deletions Misc/NEWS.d/next/Library/2024-05-21-20-13-23.gh-issue-118911.iG8nMq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
To match IPython's behaviour, updated `maybe-accept`'s logic so that if the user hits enter twice, they are able to terminate the block even if there's trailing whitespace.
Also, trimming trailing whitespace in HistoricalReader so that when the user hits arrow up, the cursor is on the last functional line. This matches IPython's behavior.
In PyREPL, updated ``maybe-accept``'s logic so that if the user hits
:kbd:`Enter` twice, they are able to terminate the block even if there's
trailing whitespace. Also, now when the user hits arrow up, the cursor
is on the last functional line. This matches IPython's behavior.
Patch by Aya Elsayed.
Loading