Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Fix missing atomic in dict_resize #119312

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented May 21, 2024

Use atomic to assign to PyDictValues->valid like we do elsewhere

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport this to 3.13

@DinoV DinoV added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@DinoV
Copy link
Contributor Author

DinoV commented May 22, 2024

We should backport this to 3.13

Backport to 3.13: #119416

@DinoV DinoV merged commit 2b3fb76 into python:main May 22, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
Fix missing atomic in dict_resize
(cherry picked from commit 2b3fb76)

Co-authored-by: Dino Viehland <dinoviehland@meta.com>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119417 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
DinoV added a commit that referenced this pull request May 22, 2024
)

gh-117657: Fix missing atomic in dict_resize (GH-119312)

Fix missing atomic in dict_resize
(cherry picked from commit 2b3fb76)

Co-authored-by: Dino Viehland <dinoviehland@meta.com>
@DinoV DinoV deleted the nogil_dict_resize branch May 31, 2024 18:21
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants