Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring #119216

Merged
merged 5 commits into from
May 21, 2024
Merged

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring #119216

merged 5 commits into from
May 21, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 20, 2024 •
edited by github-actions bot
Loading

@iritkatriel iritkatriel requested a review from scoder May 20, 2024 14:55
@bedevere-app bedevere-app bot mentioned this pull request May 20, 2024
Closed
@iritkatriel iritkatriel removed the request for review from gvanrossum May 20, 2024 14:55
markshannon
markshannon requested changes May 20, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible NULL dereference needs fixing. Looks good, otherwise.

Python/instrumentation.c Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from markshannon May 21, 2024 17:51
@iritkatriel iritkatriel enabled auto-merge (squash) May 21, 2024 20:02
@iritkatriel iritkatriel merged commit 6e9863d into python:main May 21, 2024
56 of 57 checks passed
@scoder
Copy link
Contributor

scoder commented May 24, 2024

This needs backporting to 3.13.

@scoder scoder added the needs backport to 3.13 bugs and security fixes label May 24, 2024
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@iritkatriel @miss-islington
pythongh-118692: Avoid creating unnecessary StopIteration instances f…
06943e2 
…or monitoring (pythonGH-119216)

(cherry picked from commit 6e9863d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 24, 2024

GH-119497 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
@scoder scoder added the 3.13 bugs and security fixes label May 24, 2024
iritkatriel added a commit that referenced this pull request May 24, 2024
@miss-islington @iritkatriel
[3.13] gh-118692: Avoid creating unnecessary StopIteration instances …
c864efb 
…for monitoring (GH-119216) (#119497)

* gh-118692: Avoid creating unnecessary StopIteration instances for monitoring (GH-119216)
(cherry picked from commit 6e9863d)

---------

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-118692: Avoid creating unnecessary StopIteration instances f…
4eb906e 
…or monitoring (python#119216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@scoder scoder Awaiting requested review from scoder

Assignees
No one assigned
Labels
3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid creating a StopIteration instance for monitoring
3 participants
@iritkatriel @scoder @markshannon