Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118876: Set ns.temp before invoking its is_absolute method #118880

Merged
merged 1 commit into from
May 13, 2024
Merged

gh-118876: Set ns.temp before invoking its is_absolute method #118880

merged 1 commit into from
May 13, 2024

Conversation

i-shenl
Copy link
Contributor

@i-shenl i-shenl commented May 10, 2024 •
edited by bedevere-app bot
Loading

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.

@i-shenl i-shenl requested a review from a team as a code owner May 10, 2024 06:15
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented May 10, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2024
Closed
zooba
zooba reviewed May 10, 2024
View reviewed changes
PC/layout/main.py
Comment on lines -628 to -629
# Put temp on a Dev Drive for speed if we're copying to one.
# If not, the regular temp dir will have to do.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@i-shenl i-shenl force-pushed the fix-issue-118876 branch from 11379d8 to 903eab1 Compare May 10, 2024 15:43
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@i-shenl
pythongh-118876: Set ns.temp before invoking its is_absolute method
c5cc28c 
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
@i-shenl i-shenl force-pushed the fix-issue-118876 branch from 903eab1 to c5cc28c Compare May 10, 2024 15:55
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@zooba zooba merged commit d8a82cc into python:main May 13, 2024
33 checks passed
@zooba zooba added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 13, 2024
@miss-islington-app
Copy link

Thanks @i-shenl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @i-shenl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@i-shenl @miss-islington
pythongh-118876: Ensure PC/layout sets ns.temp before using it (pytho…
0b2668d 
…nGH-118880)

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)

Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@i-shenl @miss-islington
pythongh-118876: Ensure PC/layout sets ns.temp before using it (pytho…
6770f2d 
…nGH-118880)

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)

Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

GH-118994 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

GH-118995 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024
zooba pushed a commit that referenced this pull request May 13, 2024
@miss-islington @i-shenl
gh-118876: Ensure PC/layout sets ns.temp before using it (GH-118880)
2430729 
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)

Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
zooba pushed a commit that referenced this pull request May 13, 2024
@miss-islington @i-shenl
gh-118876: Ensure PC/layout sets ns.temp before using it (GH-118880)
44995aa 
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)

Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@i-shenl @estyxx
pythongh-118876: Ensure PC/layout sets ns.temp before using it (pytho…
28c559e 
…nGH-118880)

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-shenl @zooba