Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format None, True, False and NotImplemented as literals #118758

Merged
merged 2 commits into from
May 8, 2024
Merged

Format None, True, False and NotImplemented as literals #118758

merged 2 commits into from
May 8, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 8, 2024 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 bug and security fixes labels May 8, 2024
AlexWaygood
AlexWaygood reviewed May 8, 2024
View reviewed changes
Misc/NEWS.d/3.11.0b1.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/3.12.0a1.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/3.13.0a1.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/3.13.0a2.rst Outdated Show resolved Hide resolved
@rhettinger rhettinger removed request for a team and rhettinger May 8, 2024 15:12
JelleZijlstra
JelleZijlstra reviewed May 8, 2024
View reviewed changes
Doc/c-api/object.rst Outdated Show resolved Hide resolved
@serhiy-storchaka @JelleZijlstra @AlexWaygood
Apply suggestions from code review
3cdb8d9 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit 05c2fe1 into python:main May 8, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-none-literal branch May 8, 2024 19:35
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05c2fe1acda9ea5a57061642c36e8b73bb4fbba4 3.12

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 8, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka @miss-islington
Format None, True, False and NotImplemented as literals (pythonGH-118758
1ee2c7b 
)

(cherry picked from commit 05c2fe1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2024

GH-118792 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 8, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka
Format None, True, False and NotImplemented as literals (pythonGH-118758
392bd67 
)

(cherry picked from commit 05c2fe1)
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2024

GH-118794 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 8, 2024
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@miss-islington @serhiy-storchaka
[3.13] Format None, True, False and NotImplemented as literals (GH-11…
8f31af6 
…8758) (GH-118792)

(cherry picked from commit 05c2fe1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@serhiy-storchaka
[3.12] Format None, True, False and NotImplemented as literals (GH-11…
530c3bb 
…8758) (GH-118794)

(cherry picked from commit 05c2fe1)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@rhettinger rhettinger rhettinger approved these changes

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @JelleZijlstra @rhettinger @gvanrossum @AlexWaygood