-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-118263: Generalize path_t
for C level optimizations
#118355
Conversation
@eryksun, I wasn't able to use this for I was able to speed up |
I think you'll be particularly pleased with this addition (I don't know why we didn't do this earlier): Lines 5564 to 5569 in 19209c6
|
This comment was marked as resolved.
This comment was marked as resolved.
The converter could set a flag in the
This change shouldn't affect anything compatibility-wise, and if so that needs to be addressed. It's support code for CPython. I think it could be added to beta 2 this month if it misses beta 1. |
I added a suppress option, which tells argument clinic you would like to handle errors manually, otherwise |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@eryksun, could you add backport labels? I also want to backport it to 3.12 (with the necessary changes) to use for |
Thanks, do you think this looks ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! path_t
might be my favourite thing about argument clinic, so great to see it getting even better.
One question and one comment below.
Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…type) in posixmodule (pythonGH-118355) (cherry picked from commit 96b392d) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sorry, @nineteendo and @zooba, I could not cleanly backport this to
|
GH-119513 is a backport of this pull request to the 3.13 branch. |
|
|
|
|
|
No issue, the buildbots simply ran out of space. |
…type) in posixmodule (pythonGH-118355)
GH-119608 is a backport of this pull request to the 3.12 branch. |
…type) in posixmodule (pythonGH-118355)
Benchmark:
ntpath.py
script
Note: no difference for
ntpath.is*()
,ntpath.exists()
&ntpath.lexists()
.posixpath.py
script
path_t
for C level optimizations #118263