Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-118124: Fix Py_BUILD_ASSERT on non-constant expression #118125

Closed
wants to merge 1 commit into from
Closed

GH-118124: Fix Py_BUILD_ASSERT on non-constant expression #118125

wants to merge 1 commit into from

Conversation

namniav
Copy link

@namniav namniav commented Apr 20, 2024 •
edited by bedevere-app bot
Loading

  1. Adds macro Py_CONCAT to concatenate pre-processor tokens.
  2. Deprecates Py_BUILD_ASSERT and uses static_assert instead.
  3. Prohibits non-constant expressions on Py_BUILD_ASSERT_EXPR.

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Apr 20, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Apr 20, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Apr 20, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vstinner vstinner mentioned this pull request Apr 29, 2024
Merged
@vstinner
Copy link
Member

See also PR gh-118398.

@namniav namniav closed this Apr 29, 2024
@namniav namniav deleted the fix-issue-118124 branch April 30, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namniav @vstinner