Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the argument names for secrets.choice and secrets.randbelow in secrets.rst #118098

Merged
merged 1 commit into from
May 10, 2024

Conversation

adamtheturtle
Copy link
Contributor

@adamtheturtle adamtheturtle commented Apr 19, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 19, 2024
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be best positional-only, but it's much too late for that now. The docs should match the API.

@encukou encukou enabled auto-merge (squash) May 10, 2024 14:27
@encukou encukou added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 10, 2024
@encukou encukou merged commit c444362 into python:main May 10, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @adamtheturtle for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
…w` in `secrets.rst` (pythonGH-118098)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
(cherry picked from commit c444362)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
…w` in `secrets.rst` (pythonGH-118098)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
(cherry picked from commit c444362)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

GH-118906 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

GH-118907 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 10, 2024
encukou pushed a commit that referenced this pull request May 10, 2024
…andbelow` in `secrets.rst` (GH-118098) (GH-118907)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst` (GH-118098)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
(cherry picked from commit c444362)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
encukou pushed a commit that referenced this pull request May 10, 2024
…andbelow` in `secrets.rst` (GH-118098) (GH-118906)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst` (GH-118098)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
(cherry picked from commit c444362)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…w` in `secrets.rst` (pythonGH-118098)

Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants