GH-79634: Speed up pathlib globbing by removing joinpath() call.
#114623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `self.joinpath('')` call that should have been removed in 6313cdd.
This makes `PathBase.glob('')` yield itself *without* adding a trailing
slash. It's hard to say whether this is more or less correct, but at least
everything else is faster, and there's no behaviour change in the public
classes where empty glob patterns are disallowed.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ll. (python#114623) Remove `self.joinpath('')` call that should have been removed in 6313cdd. This makes `PathBase.glob('')` yield itself *without* adding a trailing slash. It's hard to say whether this is more or less correct, but at least everything else is faster, and there's no behaviour change in the public classes where empty glob patterns are disallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
self.joinpath('')call that should have been removed in 6313cdd.This makes
PathBase.glob('')yield itself without adding a trailing slash. It's hard to say whether this is more or less correct, but at least everything else is faster, and there's no behaviour change in the public classes where empty glob patterns are disallowed.