Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter. Add the ArgResolver class. #112722

Merged
merged 19 commits into from
Dec 9, 2023
Merged

gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter. Add the ArgResolver class. #112722

merged 19 commits into from
Dec 9, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 4, 2023 •
edited
Loading

This is a pure refactor, which shouldn't change any functionality.
The goal is to make this pluggable, so that each part can be replaced by a user defined one. This PR is jut a first step.

@bedevere-app bedevere-app bot mentioned this pull request Dec 4, 2023
Closed
@iritkatriel iritkatriel marked this pull request as draft December 4, 2023 19:17
@iritkatriel
Copy link
Member Author

Marking as draft because I want to make a few more changes.

@iritkatriel iritkatriel changed the title gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter. Add the ArgResolver class to make that pluggable. Dec 4, 2023
@iritkatriel iritkatriel changed the title gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter. Add the ArgResolver class to make that pluggable. gh-112720: Move instruction formatting from the dis.Instruction class to a new class dis.InstructionFormatter. Add the ArgResolver class. Dec 4, 2023
@iritkatriel iritkatriel marked this pull request as ready for review December 4, 2023 23:57
@iritkatriel
Copy link
Member Author

I'd like to put the caches information on the Instruction rather than create fake instructions for it. But that should be in its own PR, so I'm going to stop working on this one.

markshannon
markshannon reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

Lib/dis.py Outdated Show resolved Hide resolved
Lib/dis.py Outdated Show resolved Hide resolved
Lib/dis.py Outdated Show resolved Hide resolved
markshannon
markshannon reviewed Dec 8, 2023
View reviewed changes
Lib/dis.py Show resolved Hide resolved
@iritkatriel iritkatriel enabled auto-merge (squash) December 9, 2023 09:49
@iritkatriel iritkatriel merged commit c98c402 into python:main Dec 9, 2023
22 checks passed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112720: Move instruction formatting from the dis.Instruction…
c1327f7 
… class to a new class dis.InstructionFormatter. Add the ArgResolver class. (python#112722)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112720: Move instruction formatting from the dis.Instruction…
2b22608 
… class to a new class dis.InstructionFormatter. Add the ArgResolver class. (python#112722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iritkatriel @markshannon