gh-110190: Fix ctypes structs with array on Arm #112604

diegorusso · 2023-12-01T17:54:22Z

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.
This because on Arm platforms structs with at most 4 elements of any
floating point type values can be passed through registers. If the type
is double the maximum size of the struct is 32 bytes.
By Arm platforms it is meant 32 and 64 bit.
On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.

Issue: ctypes array cannot be returned by value on ARM64 #110190

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.

cpython-cla-bot · 2023-12-01T17:54:25Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2023-12-01T17:54:26Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-bot · 2023-12-01T18:43:00Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 34f9c99 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Modules/_ctypes/stgdict.c

ambv · 2023-12-05T15:25:54Z

Thanks, Diego! ✨ 🍰 ✨

miss-islington-app · 2023-12-05T15:55:04Z

Thanks @diegorusso for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app · 2023-12-05T15:55:04Z

Thanks @diegorusso for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2023-12-05T15:55:07Z

Sorry, @diegorusso and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bc68f4a4abcfbea60bb1db1ccadb07613561931c 3.11

miss-islington-app · 2023-12-05T15:55:18Z

Sorry, @diegorusso and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bc68f4a4abcfbea60bb1db1ccadb07613561931c 3.12

…112604) Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate. (cherry picked from commit bc68f4a)

bedevere-app · 2023-12-05T17:29:20Z

GH-112766 is a backport of this pull request to the 3.11 branch.

…112604) Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate. (cherry picked from commit bc68f4a)

…ngh-112604 on PPC64LE (pythonGH-112818) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…n PPC64LE (GH-112818) (#112829) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…ngh-112604 on PPC64LE (pythonGH-112818) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

diegorusso · 2023-12-07T16:24:35Z

@sunmy2019 This is an old document. The right version is https://files.openpower.foundation/s/cfA2oFPXbbZwEBK. Read my comment here: #110190 (comment)

…n PPC64LE (GH-112818) (#112830) (cherry picked from commit 9f67042)

Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

diegorusso · 2023-12-11T14:16:01Z

@sunmy2019 and @Yhg1s the issue on PPC64LE has been fixed with #112959

Fix the same issue of PR #112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

…honGH-112959) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310

…honGH-112959) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I31730a3ebe558570ce1d7a3b26db8392f18d1770

#113167) Fix the same issue of PR #112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310

#113170) Fix the same issue of PR #112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I31730a3ebe558570ce1d7a3b26db8392f18d1770

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.

on PPC64LE (python#112818)

…12959) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.

on PPC64LE (python#112818)

…12959) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

…112604) (python#112766) Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate. (cherry picked from commit bc68f4a) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830) (cherry picked from commit 9f67042) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…honGH-112959) (python#113167) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310 Signed-off-by: Michał Górny <mgorny@gentoo.org>

…112604) (python#112766) Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate. (cherry picked from commit bc68f4a) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830) (cherry picked from commit 9f67042) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…honGH-112959) (python#113167) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310 Signed-off-by: Michał Górny <mgorny@gentoo.org>

…112604) (python#112766) Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms. This because on Arm platforms structs with at most 4 elements of any floating point type values can be passed through registers. If the type is double the maximum size of the struct is 32 bytes. On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate. (cherry picked from commit bc68f4a) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830) (cherry picked from commit 9f67042) Signed-off-by: Michał Górny <mgorny@gentoo.org>

…honGH-112959) (python#113167) Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed. (cherry picked from commit 6644ca4) Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310 Signed-off-by: Michał Górny <mgorny@gentoo.org>

bedevere-app bot added the awaiting review label Dec 1, 2023

bedevere-app bot mentioned this pull request Dec 1, 2023

ctypes array cannot be returned by value on ARM64 #110190

Closed

📜🤖 Added by blurb_it.

34f9c99

ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 1, 2023

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 1, 2023

Merge branch 'python:main' into main

3c1acd7

ambv approved these changes Dec 4, 2023

View reviewed changes

Modules/_ctypes/stgdict.c Outdated Show resolved Hide resolved

Modules/_ctypes/stgdict.c Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting review labels Dec 4, 2023

diegorusso added 3 commits December 5, 2023 09:58

Merge branch 'python:main' into main

1802f5e

Address comments in the PR

4368b2f

Merge branch 'main' into main

482af77

ambv merged commit bc68f4a into python:main Dec 5, 2023

bedevere-app bot removed the awaiting merge label Dec 5, 2023

ambv added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Dec 5, 2023

miss-islington-app bot assigned ambv Dec 5, 2023

bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 5, 2023

ambv added a commit to ambv/cpython that referenced this pull request Dec 7, 2023

[3.12] pythongh-110190: Temporarily skip new test introduced in pytho…

951aa62

…ngh-112604 on PPC64LE (pythonGH-112818) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

Yhg1s pushed a commit that referenced this pull request Dec 7, 2023

[3.12] gh-110190: Temporarily skip new test introduced in gh-112604 o…

8f1c912

…n PPC64LE (GH-112818) (#112829) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

ambv added a commit to ambv/cpython that referenced this pull request Dec 7, 2023

[3.11] pythongh-110190: Temporarily skip new test introduced in pytho…

832bb54

…ngh-112604 on PPC64LE (pythonGH-112818) (cherry picked from commit 9f67042) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

ambv added a commit that referenced this pull request Dec 8, 2023

[3.11] gh-110190: Temporarily skip new test introduced in gh-112604 o…

1e6d36d

…n PPC64LE (GH-112818) (#112830) (cherry picked from commit 9f67042)

diegorusso added a commit to diegorusso/cpython that referenced this pull request Dec 11, 2023

pythongh-110190: Fix ctypes structs with array on PPCLE64

b7f949b

Fix the same issue of PR python#112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

diegorusso mentioned this pull request Dec 11, 2023

gh-110190: Fix ctypes structs with array on PPCLE64 #112959

Merged

ambv pushed a commit that referenced this pull request Dec 13, 2023

gh-110190: Fix ctypes structs with array on PPCLE64 (GH-112959)

6644ca4

Fix the same issue of PR #112604 on PPC64LE platform Refactor tests to make easier to add more platfroms if needed.

diegorusso mentioned this pull request Dec 15, 2023

[3.11] gh-110190: Fix ctypes structs with array on PPCLE64 (GH-112959) #113167

Merged

diegorusso mentioned this pull request Dec 15, 2023

[3.12] gh-110190: Fix ctypes structs with array on PPCLE64 (GH-112959) #113170

Merged

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-110190: Temporarily skip new test introduced in pythongh-112604

d4c5624

on PPC64LE (python#112818)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-110190: Temporarily skip new test introduced in pythongh-112604

b7d628e

on PPC64LE (python#112818)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-110190: Fix ctypes structs with array on Arm #112604

gh-110190: Fix ctypes structs with array on Arm #112604

diegorusso commented Dec 1, 2023 •

edited

Loading

cpython-cla-bot bot commented Dec 1, 2023 •

edited

Loading

bedevere-app bot commented Dec 1, 2023

bedevere-bot commented Dec 1, 2023

ambv commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

bedevere-app bot commented Dec 5, 2023

diegorusso commented Dec 7, 2023

diegorusso commented Dec 11, 2023

gh-110190: Fix ctypes structs with array on Arm #112604

gh-110190: Fix ctypes structs with array on Arm #112604

Conversation

diegorusso commented Dec 1, 2023 • edited Loading

cpython-cla-bot bot commented Dec 1, 2023 • edited Loading

bedevere-app bot commented Dec 1, 2023

bedevere-bot commented Dec 1, 2023

ambv commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

miss-islington-app bot commented Dec 5, 2023

bedevere-app bot commented Dec 5, 2023

diegorusso commented Dec 7, 2023

diegorusso commented Dec 11, 2023

diegorusso commented Dec 1, 2023 •

edited

Loading

cpython-cla-bot bot commented Dec 1, 2023 •

edited

Loading