Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110964: Remove private _PyArg functions #110966

Merged
merged 2 commits into from
Oct 17, 2023
Merged

gh-110964: Remove private _PyArg functions #110966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a846d
gh-110964: Remove private _PyArg functions
vstinner Oct 17, 2023
8a4f9af
Fix mypy --config-file Tools/clinic/mypy.ini
vstinner Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix mypy --config-file Tools/clinic/mypy.ini
  • Loading branch information
@vstinner
vstinner committed Oct 17, 2023
commit 8a4f9af1905fc43527017808fcbbd7fb28c23086
17 changes: 9 additions & 8 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,21 +1432,22 @@ def parser_body(
deprecated_keywords[i] = p

has_optional_kw = (max(pos_only, min_pos) + min_kw_only < len(converters) - int(vararg != NO_VARARG))
if limited_capi:
args_declaration = None
nargs = None
elif vararg == NO_VARARG:
clinic.add_include('pycore_modsupport.h',
'_PyArg_UnpackKeywords()')
if vararg == NO_VARARG:
# FIXME: refactor the code to not declare args_declaration
# if limited_capi is true
if not limited_capi:
clinic.add_include('pycore_modsupport.h',
'_PyArg_UnpackKeywords()')
args_declaration = "_PyArg_UnpackKeywords", "%s, %s, %s" % (
min_pos,
max_pos,
min_kw_only
)
nargs = "nargs"
else:
clinic.add_include('pycore_modsupport.h',
'_PyArg_UnpackKeywordsWithVararg()')
if not limited_capi:
clinic.add_include('pycore_modsupport.h',
'_PyArg_UnpackKeywordsWithVararg()')
args_declaration = "_PyArg_UnpackKeywordsWithVararg", "%s, %s, %s, %s" % (
min_pos,
max_pos,
Expand Down