Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] bpo-42663: Fix parsing TZ strings in zoneinfo module (GH-23825) #110882

Merged

Conversation

serhiy-storchaka
Copy link
Member

zipinfo now supports the full range of values in the TZ string determined by RFC 8536 and detects all invalid formats. Both Python and C implementations now raise exceptions of the same type on invalid data.
(cherry picked from commit ab08ff7)

…-23825)

zipinfo now supports the full range of values in the TZ string
determined by RFC 8536 and detects all invalid formats.
Both Python and C implementations now raise exceptions of the same
type on invalid data..
(cherry picked from commit ab08ff7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot added awaiting core review type-bug An unexpected behavior, bug, or error labels Oct 14, 2023
@bedevere-app bedevere-app bot added the type-feature A feature request or enhancement label Oct 14, 2023
@serhiy-storchaka serhiy-storchaka merged commit 72b0f0e into python:3.12 Oct 15, 2023
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label Oct 15, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-ab08ff7-3.12 branch October 15, 2023 07:59
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 72b0f0eaf52ac46d5f6e165f737d6f891cf8d172 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 15, 2023
…ythonGH-23825) (pythonGH-110882)

zipinfo now supports the full range of values in the TZ string
determined by RFC 8536 and detects all invalid formats.
Both Python and C implementations now raise exceptions of the same
type on invalid data.
(cherry picked from commit ab08ff7).
(cherry picked from commit 72b0f0e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2023

GH-110889 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 15, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 15, 2023
serhiy-storchaka added a commit that referenced this pull request Oct 15, 2023
…H-23825) (GH-110882) (GH-110889)

zipinfo now supports the full range of values in the TZ string
determined by RFC 8536 and detects all invalid formats.
Both Python and C implementations now raise exceptions of the same
type on invalid data.
(cherry picked from commit ab08ff7)
(cherry picked from commit 72b0f0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants