Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109634: Fix :samp: syntax #110073

Merged
merged 2 commits into from
Sep 29, 2023
Merged

gh-109634: Fix :samp: syntax #110073

merged 2 commits into from
Sep 29, 2023

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Sep 29, 2023 •
edited by bedevere-app bot
Loading

What

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 29, 2023
@JacobCoffee JacobCoffee mentioned this pull request Sep 29, 2023
Merged
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 bug and security fixes label Sep 29, 2023
@AA-Turner AA-Turner changed the title gh-109778: apply :samp: fixes found in #109778 gh-109778: Fix :samp: syntax Sep 29, 2023
@AA-Turner AA-Turner changed the title gh-109778: Fix :samp: syntax gh-109634: Fix :samp: syntax Sep 29, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit e27adc6 into python:main Sep 29, 2023
@miss-islington
Copy link
Contributor

Thanks @JacobCoffee for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
@JacobCoffee @miss-islington
pythongh-109634: Fix :samp: syntax (pythonGH-110073)
5417229 
(cherry picked from commit e27adc6)

Co-authored-by: Jacob Coffee <jacob@z7x.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110095 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 29, 2023
Yhg1s pushed a commit that referenced this pull request Sep 29, 2023
@miss-islington @JacobCoffee
[3.12] gh-109634: Fix :samp: syntax (GH-110073) (#110095)
8882b30 
gh-109634: Fix `:samp:` syntax (GH-110073)
(cherry picked from commit e27adc6)

Co-authored-by: Jacob Coffee <jacob@z7x.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@JacobCoffee @Glyphack
pythongh-109634: Fix :samp: syntax (pythonGH-110073)
5a41cde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@hugovk hugovk hugovk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacobCoffee @miss-islington @hugovk @serhiy-storchaka @AA-Turner