Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109408: Move Windows builds from Azure Pipelines PR to GitHub Actions #109569

Merged
merged 3 commits into from
Sep 20, 2023
Merged

gh-109408: Move Windows builds from Azure Pipelines PR to GitHub Actions #109569

merged 3 commits into from
Sep 20, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 19, 2023 •
edited
Loading

Situation now

There are two top-level pipelines on Azure Pipelines:

The Azure Pipelines CI pipeline does this for Windows:

  • Build and test for win32
  • Build and test for win64
  • Some layout tests

The Azure Pipelines PR pipeline does this for Windows:

  • Build and test for win32
  • Build and test for win64
  • Build for arm64 (but not test because it would need to run on the same architecture)

GitHub Actions does this for Windows:

  • Build and test for win32
  • Build and test for win64

Changes in this PR

Azure Pipelines CI pipeline:

  • Build and test for win32 (no change)
  • Build and test for win64 (no change)
  • Some layout tests (no change)

Azure Pipelines PR pipeline:

  • Build and test for win32 (removed)
  • Build and test for win64 (removed)
  • Build for arm64 (removed)

GitHub Actions:

  • Build and test for win32 (no change)
  • Build and test for win64 (no change)
  • Add arm64 build (added)
    • Allowed to fail
  • This now matches what Azure Pipelines PR did

Questions

@zooba Couple of questions:

  • Would you like an arm64 build on Azure Pipelines CI? Edit: No
  • Do we want the arm64 build on GitHub Actions? Edit: Yes

@hugovk
Add Windows arm64 to GitHub Actions
5d9894e
@hugovk
Specify a recent stable version to remove warning
2b93f34 
Remove this warning from GHA's annotations/warnings:

The 'python-version' input is not set. The version of Python currently in 'PATH' will be used.
@hugovk
Remove Windows builds from Azure Pipelines
47ceaec
@bedevere-app bedevere-app bot mentioned this pull request Sep 19, 2023
Closed
@zooba
Copy link
Member

zooba commented Sep 20, 2023

I'm not sure my Azure credit will cover the full month, but I already have an ARM64 VM attached to AzDO that could run tests. It's used for the PGO training for releases, and I normally only run it for release builds.

But we already have buildbots, so those are fine for now. When we can enable an ARM64 test for free on either GHA or AzDO, then we can do it.

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 20, 2023
@hugovk
Copy link
Member Author

hugovk commented Sep 20, 2023

Thanks, let's merge this PR as-is then.

@hugovk hugovk merged commit 14cdefa into python:main Sep 20, 2023
@hugovk hugovk deleted the ci-win-ap2gha branch September 20, 2023 18:56
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 14cdefa667f211401c9dfab33c4695e80b4e5e95 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2023
@hugovk @miss-islington
pythongh-109408: Move Windows builds from Azure Pipelines PR to GitHu…
ec5fdc7 
…b Actions (pythonGH-109569)

(cherry picked from commit 14cdefa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 20, 2023

GH-109623 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 20, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 20, 2023

GH-109624 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 20, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 20, 2023
@hugovk
[3.11] pythongh-109408: Move Windows builds from Azure Pipelines PR t…
b40067d 
…o GitHub Actions (pythonGH-109569)

(cherry picked from commit 14cdefa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Sep 20, 2023
@hugovk
[3.11] gh-109408: Move Windows builds from Azure Pipelines PR to GitH…
9414ddf 
…ub Actions (GH-109569) (#109624)
Yhg1s pushed a commit that referenced this pull request Sep 22, 2023
@miss-islington @hugovk
[3.12] gh-109408: Move Windows builds from Azure Pipelines PR to GitH…
92a3479 
…ub Actions (GH-109569) (#109623)

gh-109408: Move Windows builds from Azure Pipelines PR to GitHub Actions (GH-109569)
(cherry picked from commit 14cdefa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@hugovk @csm10495
pythongh-109408: Move Windows builds from Azure Pipelines PR to GitHu…
1606625 
…b Actions (python#109569)
@hugovk hugovk mentioned this pull request Sep 29, 2023
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk @Glyphack
pythongh-109408: Move Windows builds from Azure Pipelines PR to GitHu…
210eef5 
…b Actions (python#109569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@hugovk hugovk

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @zooba @miss-islington