Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-109466: Add ipv6_mapped property to IPv4Address #109467

Merged
merged 10 commits into from
Nov 5, 2023

Conversation

csm10495
Copy link
Contributor

@csm10495 csm10495 commented Sep 15, 2023

Updated docs and added a corresponding unit test.

Fixes #109466.


📚 Documentation preview 📚: https://cpython-previews--109467.org.readthedocs.build/

@csm10495
Copy link
Contributor Author

@asvetlov I think you were a more recent committer here. Any chance for a review? Thanks!

@csm10495
Copy link
Contributor Author

Friendly ping @asvetlov. Thanks.

@hugovk hugovk changed the title gh-109466 Add ipv6_mapped property to IPV4Address gh-109466: Add ipv6_mapped property to IPV4Address Nov 5, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone else review whether this is needed, but here's some docs suggestions.

Doc/library/ipaddress.rst Outdated Show resolved Hide resolved
Lib/ipaddress.py Outdated Show resolved Hide resolved
Lib/ipaddress.py Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
gpshead and others added 5 commits November 5, 2023 08:14
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…ah-aw.rst

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gpshead gpshead self-assigned this Nov 5, 2023
@gpshead gpshead added the type-feature A feature request or enhancement label Nov 5, 2023
@gpshead gpshead enabled auto-merge (squash) November 5, 2023 16:23
@gpshead gpshead changed the title gh-109466: Add ipv6_mapped property to IPV4Address gh-109466: Add ipv6_mapped property to IPv4Address Nov 5, 2023
@gpshead gpshead merged commit ba8aa1f into python:main Nov 5, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Adds the `IPv4Address.ipv6_mapped` property.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@jstasiak
Copy link
Contributor

Cross-referencing #119814 for visibility.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Adds the `IPv4Address.ipv6_mapped` property.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ipv6_mapped property to IPv4Address
4 participants