Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108444: Argument Clinic uses PyLong_AsInt() #108458

Merged
merged 2 commits into from
Aug 24, 2023
Merged

gh-108444: Argument Clinic uses PyLong_AsInt() #108458

merged 2 commits into from
Aug 24, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 24, 2023 •
edited by bedevere-bot
Loading

Argument Clinic now uses the new public PyLong_AsInt(), rather than the old name _PyLong_AsInt().

@vstinner
pythongh-108444: Argument Clinic uses PyLong_AsInt()
100c99d 
Argument Clinic now uses the new public PyLong_AsInt(), rather than
the old name _PyLong_AsInt().
@bedevere-bot bedevere-bot mentioned this pull request Aug 24, 2023
Closed
@vstinner vstinner merged commit 4e5a728 into python:main Aug 24, 2023
@vstinner vstinner deleted the clinic_long_asint branch August 24, 2023 22:51
@vstinner
Copy link
Member Author

Merged, thanks for the review.

@erlend-aasland
Copy link
Contributor

Oh, yeah, you need make clinic-tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @erlend-aasland @AlexWaygood @bedevere-bot