Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: Add --exclude option to Argument Clinic CLI #107770

Merged
merged 8 commits into from
Aug 8, 2023
Merged

gh-104683: Add --exclude option to Argument Clinic CLI #107770

merged 8 commits into from
Aug 8, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 8, 2023 •
edited by github-actions bot
Loading

Explicitly exclude Lib/test/clinic.test.c when running make clinic.

📚 Documentation preview 📚: https://cpython-previews--107770.org.readthedocs.build/

@erlend-aasland
pythongh-104683: Add --exclude option to Argument Clinic CLI
bb701b7 
Explicitly exclude Lib/test/clinic.test.c when running make clinic.
@bedevere-bot bedevere-bot mentioned this pull request Aug 8, 2023
Closed
7 tasks
@erlend-aasland erlend-aasland mentioned this pull request Aug 8, 2023
Merged
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

Could you please update also the makefile? And add a target clinic-tests which regenerate specifically the test file?

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

Great idea!

Thank you!

Could you please update also the makefile? And add a target clinic-tests which regenerate specifically the test file?

That is a very good idea.

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 8, 2023 11:28
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2023
View reviewed changes
Lib/test/test_clinic.py Outdated Show resolved Hide resolved
Lib/test/test_clinic.py Show resolved Hide resolved
@AlexWaygood AlexWaygood disabled auto-merge August 8, 2023 11:42
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 8, 2023 20:22
@erlend-aasland erlend-aasland merged commit 0be3743 into python:main Aug 8, 2023
@erlend-aasland erlend-aasland deleted the clinic/cli-exclude-files branch August 8, 2023 21:11
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland @serhiy-storchaka
gh-104683: Add --exclude option to Argument Clinic CLI (python/cpytho…
832ccfa 
…n#107770)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@erlend-aasland @serhiy-storchaka
python/cpython#104683: Add --exclude option to Argument Clinic CLI (p…
8dd6936 
…ython/cpython#107770)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland @serhiy-storchaka
python/cpython#104683: Add --exclude option to Argument Clinic CLI (p…
2d0204d 
…ython/cpython#107770)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @serhiy-storchaka @bedevere-bot