-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused internal _PyImport_GetModuleId() function #107235
Conversation
@ericsnowcurrently: Here is a PR to remove _PyImport_GetModuleId(). |
FTR, here's Victor's PyPI search: #107213 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming no external modules (or embedders) are using this, LGTM.
0caa13c
to
9f3f713
Compare
Hum, the CLA Signing job was blocked. So I closed/reopened my PR and also rebased it on the main branch. Let's see if this time, the job starts. |
Strange. Python |
I reported the issue to ReadTheDocs bug tracker: readthedocs/readthedocs.org#10567 |
I checked again: I found no user in PyPI top 5,000 projects (2023-07-04):
The 2 results are only comments to say that PyO3-ffi has no binding for _PyImport_GetModuleId(). |
I closed/reopened again the PR to trigger a new ReadTheDocs job. Right now, the job is failing with:
|
Merged, thanks for the review @ericsnowcurrently. |
No description provided.