Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-106970: Fix Argument Clinic 'destination <name> clear' command (#106972) #107059

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 22, 2023

Add test for the 'destination clear' command,
and the 'destination' directive in general.

Fix two bugs in 'destination clear' command:

  1. The text attribute of the allocator is called 'text', not '_text'
  2. Return after processing the 'clear' command,
    instead of proceeding directly to the fail().

(cherry picked from commit 3372bcb)

…' command (python#106972)

Add test for the 'destination <name> clear' command,
and the 'destination' directive in general.

Fix two bugs in 'destination <name> clear' command:

1. The text attribute of the allocator is called 'text', not '_text'
2. Return after processing the 'clear' command,
   instead of proceeding directly to the fail().

(cherry picked from commit 3372bcb)
@erlend-aasland
Copy link
Contributor Author

FTR, test_unknown_destination_command() was accidentally added in gh-107002. Originally it was a part of gh-106972, so it should have been a part of this backport as well.

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 22, 2023 17:25
@erlend-aasland erlend-aasland merged commit 63c945a into python:3.11 Jul 22, 2023
@erlend-aasland erlend-aasland deleted the backport-3.11-clinic-dest-clear-fix branch July 22, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants