Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106531: Remove importlib.resources._legacy #106532

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 7, 2023

Syncs with importlib_resources 6.0.

Syncs with importlib_resources 6.0.
@jaraco
Copy link
Member Author

jaraco commented Jul 14, 2023

I'm going to proceed with the merge to give as much visibility to the change as possible, but happy to revisit if needed.

@jaraco jaraco merged commit 243fdcb into python:main Jul 14, 2023
@jaraco jaraco deleted the debt/106531-importlib-resources-6 branch July 14, 2023 17:38
tacaswell added a commit to tacaswell/meson that referenced this pull request Jul 16, 2023
243fdcb40ebeb177ce723911c1f7fad8a1fdf6cb /
python/cpython#106532 removes functions deprecated in
py311.
@CAM-Gerlach
Copy link
Member

I realize this is somewhat late to the party, but is there any chance we can revert this for one release, so tools like pre-commit don't have to drop compatibility with Python 3.8 prior to it being EOL to support Python 3.13 before release (see, e.g., pre-commit/pre-commit#3042 , or else have to include a bunch of kludgy compatibility code for one Python release as in mesonbuild/meson#11998 .

tacaswell added a commit to tacaswell/meson that referenced this pull request Mar 13, 2024
243fdcb40ebeb177ce723911c1f7fad8a1fdf6cb /
python/cpython#106532 removes functions deprecated in
py311.
@jaraco
Copy link
Member Author

jaraco commented Mar 20, 2024

I realize this is somewhat late to the party, but is there any chance we can revert this for one release, so tools like pre-commit don't have to drop compatibility with Python 3.8 prior to it being EOL to support Python 3.13 before release (see, e.g., pre-commit/pre-commit#3042 , or else have to include a bunch of kludgy compatibility code for one Python release as in mesonbuild/meson#11998 .

Sorry I missed this message earlier. It's been a rough winter season for me. Huge thanks to encukou for addressing this request in #116608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants