gh-106458: Mark testthreadingmock.py with @requires_working_threading

[mariocj89]

• Issue: Allow waiting on a mock #61215

• Issue: test_unittest failing due to test/test_unittest/testmock/testthreadingmock assuming threading exists #106458

[tirkarthi]

Please add "test-with-buildbots" label once complete so that you can run the PR on all buildbots without merging that will help in testing this.

[mariocj89]

@tirkarthi can you add the label please?

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit cddd99d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[cjw296]

Looks like this test is still sad on WASM:

======================================================================
FAIL: test_wait_until_any_call_keywords (test.test_unittest.testmock.testthreadingmock.TestThreadingMock.test_wait_until_any_call_keywords)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 192, in test_wait_until_any_call_keywords
    self.assertNotIn(call(a=1), something.method_1.mock_calls)
AssertionError: call(a=1) unexpectedly found in [call(a=1)]
----------------------------------------------------------------------

Given the diff in this PR, I wonder why it's still being run?

[mariocj89]

That tests a race condition. Seems the two lines after that take more than 100ms, let me fix it

[mariocj89]

Can you trigger another run of buildbots?

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit f3d8389 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[mariocj89]

This should be good to land @cjw296, the failing build bots are in venv, extensions or grammar, which is unrelated from the change we did.

[brettcannon]

@mariocj89 unfortunately there's now a merge conflict.

[brettcannon]

While we wait on the merge conflict to be fixed, I opened #106458 to track this specific test failure.

[cjw296]

@mariocj89 - this change and the ones below confuse me, are they intentional or just a result of a bad attempt of mine to resolve the conflicts?

[mariocj89]

This is indeed part of the change. Trying to reduce the chance of a race condition (as that's what this test is doing though)

[mariocj89]

I've just rebased all change son top of main, should be good to go

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 78d9031 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[brettcannon]

Thanks!