Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92536: Argument Clinic no longer emits PyUnicode_READY() #105208

Merged
merged 2 commits into from
Jun 1, 2023
Merged

gh-92536: Argument Clinic no longer emits PyUnicode_READY() #105208

merged 2 commits into from
Jun 1, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 1, 2023 •
edited by bedevere-bot
Loading

Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.

@vstinner vstinner requested a review from a team as a code owner June 1, 2023 22:22
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Closed
@vstinner vstinner force-pushed the clinic_unicode_ready branch from e19ae66 to 4960003 Compare June 1, 2023 22:29
@vstinner
Copy link
Member Author

vstinner commented Jun 1, 2023

See also PR #105210.

@vstinner vstinner mentioned this pull request Jun 1, 2023
Merged
@vstinner vstinner force-pushed the clinic_unicode_ready branch from b321f5d to 2629844 Compare June 1, 2023 22:36
@vstinner vstinner merged commit cbb9ba8 into python:main Jun 1, 2023
@vstinner vstinner deleted the clinic_unicode_ready branch June 1, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot