Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: clinic.py: Improve coverage for the parse_converter method #104729

Merged
merged 2 commits into from
May 21, 2023
Merged

gh-104683: clinic.py: Improve coverage for the parse_converter method #104729

merged 2 commits into from
May 21, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 21, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 21, 2023
Closed
7 tasks
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 21, 2023
erlend-aasland
erlend-aasland approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) May 21, 2023 22:41
@AlexWaygood
Copy link
Member Author

I'll leave the decision to you as to whether to backport this!

@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 21, 2023
@erlend-aasland
Copy link
Contributor

I (almost) always backport tests :) We need good test coverage in all active releases.

@AlexWaygood
Copy link
Member Author

I (almost) always backport tests :) We need good test coverage in all active releases.

I do the same over at typing.py, but I know opinions differ!

@AlexWaygood AlexWaygood merged commit 64d1b44 into python:main May 21, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 64d1b44a5459605af3e8572d4febfde021315633 3.11

@AlexWaygood AlexWaygood deleted the argclinic-coverage branch May 21, 2023 23:02
@AlexWaygood AlexWaygood mentioned this pull request May 21, 2023
Merged
@bedevere-bot
Copy link

GH-104730 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request May 21, 2023
@AlexWaygood
pythongh-104683: clinic.py: Improve coverage for the `parse_convert…
b59fb65 
…er` method (python#104729)
AlexWaygood added a commit that referenced this pull request May 21, 2023
@AlexWaygood
[3.11] gh-104683: clinic.py: Improve coverage for the `parse_conver…
d691de1 
…ter` method (#104729) (#104730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @erlend-aasland @miss-islington @bedevere-bot