Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-104668: Don't call PyOS_* hooks in subinterpreters #104674

Merged
merged 6 commits into from
May 22, 2023
Merged

GH-104668: Don't call PyOS_* hooks in subinterpreters #104674

merged 6 commits into from
May 22, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented May 19, 2023 •
edited by github-actions bot
Loading

PyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter.

📚 Documentation preview 📚: https://cpython-previews--104674.org.readthedocs.build/

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-tkinter topic-subinterpreters topic-C-API labels May 19, 2023
@brandtbucher brandtbucher requested a review from pablogsal as a code owner May 19, 2023 22:19
@brandtbucher brandtbucher self-assigned this May 19, 2023
@brandtbucher brandtbucher requested a review from lysnikolaou as a code owner May 19, 2023 22:19
@bedevere-bot bedevere-bot mentioned this pull request May 19, 2023
Closed
@erlend-aasland
Copy link
Contributor

We should advertise this in What's New as well.

ericsnowcurrently
ericsnowcurrently approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtbucher brandtbucher enabled auto-merge (squash) May 22, 2023 19:25
@brandtbucher brandtbucher merged commit 357bed0 into python:main May 22, 2023
@arhadthedev
Copy link
Member

arhadthedev commented May 22, 2023 •
edited
Loading

Should we backport it to 3.12?

Edit: I noticed that the label isn't added yet.

@JelleZijlstra
Copy link
Member

@brandtbucher this didn't actually end up in the 3.12 branch. Should we backport it, or is it a new feature that should only go into 3.13?

@brandtbucher brandtbucher added the needs backport to 3.12 bug and security fixes label May 22, 2023
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@brandtbucher @miss-islington
pythonGH-104668: Don't call PyOS_* hooks in subinterpreters (pythonGH…
ef66708 
…-104674)

(cherry picked from commit 357bed0)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot
Copy link

GH-104760 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 22, 2023
@brandtbucher
Copy link
Member Author

I was waiting for the label. 🙂

brandtbucher added a commit that referenced this pull request May 23, 2023
@miss-islington @brandtbucher
[3.12] GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104760)
905d419 
GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104674)
(cherry picked from commit 357bed0)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API topic-subinterpreters topic-tkinter type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brandtbucher @erlend-aasland @arhadthedev @JelleZijlstra @miss-islington @bedevere-bot @ericsnowcurrently