-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused internal macros #102415
Remove unused internal macros #102415
Conversation
For more context, see the discussion in #17933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@corona10 @kumaraditya303 Thanks for the reviews! |
|
Since python#101826 was merged, the internal macro `_Py_InIntegralTypeRange` is unused, as are its supporting macros `_Py_IntegralTypeMax` and `_Py_IntegralTypeMin`. This PR removes them. Note that `_Py_InIntegralTypeRange` doesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.
Thanks for removing these macros :-) |
Since #101826, the internal macro
_Py_InIntegralTypeRange
is unused, as are its supporting macros_Py_IntegralTypeMax
and_Py_IntegralTypeMin
. This PR removes them.Note that
_Py_InIntegralTypeRange
doesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.