Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101860: Expose __name__ on property #101876

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Feb 13, 2023

Useful for introspection and consistent with functions and other descriptors.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@eltoder eltoder force-pushed the feature/property-name branch 3 times, most recently from 05db108 to 9c956c7 Compare February 13, 2023 18:00
@serhiy-storchaka
Copy link
Member

@eltoder, there are a lot of conflicts now. Could you please update the branch?

@serhiy-storchaka serhiy-storchaka self-requested a review February 17, 2024 08:17
Useful for introspection and consistent with functions and other
descriptors.
@eltoder eltoder force-pushed the feature/property-name branch from 9c956c7 to 8ec1251 Compare February 17, 2024 15:59
@eltoder
Copy link
Contributor Author

eltoder commented Feb 17, 2024

@serhiy-storchaka Done

@serhiy-storchaka
Copy link
Member

Thank you. I knew I could count on you.

@eltoder
Copy link
Contributor Author

eltoder commented Feb 20, 2024

@serhiy-storchaka I made __name__ default to fget.__name__ when possible. What do you think?

Raise AttributeError if no fget or it doesn't have `__name__`.
@eltoder eltoder force-pushed the feature/property-name branch from 732337d to c20e9a7 Compare February 20, 2024 04:40
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And I like to to review more of your PRs.

@serhiy-storchaka serhiy-storchaka merged commit c0b0c2f into python:main Feb 20, 2024
37 checks passed
@eltoder eltoder deleted the feature/property-name branch February 20, 2024 15:33
@eltoder
Copy link
Contributor Author

eltoder commented Feb 20, 2024

Thank you!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
Useful for introspection and consistent with functions and other
descriptors.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Useful for introspection and consistent with functions and other
descriptors.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
Useful for introspection and consistent with functions and other
descriptors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants