gh-100829: Show the Python Launcher version #100832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksis
commented
Jan 7, 2023
•
- Show the version of Python Launcher for Windows #100829 (comment)
- Issue: Show the version of Python Launcher for Windows #100829
d221f64 to
7308cac
Compare
zooba
reviewed
Jan 9, 2023
|
@zooba i update the changes for In case apply the patch add the additional dependency <Link>
<AdditionalDependencies>version.lib;shell32.lib;pathcch.lib;%(AdditionalDependencies)</AdditionalDependencies>
<SubSystem>Console</SubSystem>
</Link>Any advice, welcome! |
|
There's still discussion (on the issue) to resolve about what this is for. I don't believe it's worth adding an extra option solely for users to run themselves, which is what the current PR does. |
|
The issue has been closed, so I think this PR should be also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.