Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim #100541

Merged
merged 1 commit into from
Dec 29, 2022
Merged

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim #100541

merged 1 commit into from
Dec 29, 2022

Conversation

zware
Copy link
Member

@zware zware commented Dec 26, 2022 •
edited by bedevere-bot
Loading

As far as I can tell, this hasn't been actually used since Mac OS X 10.2.

@zware zware requested a review from a team as a code owner December 26, 2022 20:54
@zware zware added 3.12 bugs and security fixes OS-mac build The build process and cross-build topic-ctypes extension-modules C modules in the Modules dir labels Dec 26, 2022
@zware zware self-assigned this Dec 26, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 26, 2022
Closed
@zware
Copy link
Member Author

zware commented Dec 26, 2022 •
edited
Loading

!buildbot macos

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

@zware
Copy link
Member Author

zware commented Dec 26, 2022

!buildbot .*mac

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: .*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zware zware requested a review from a team December 26, 2022 21:00
@arhadthedev
Copy link
Member

Probably, this should be removed too:

cpython/Tools/c-analyzer/cpython/_parser.py

Line 54 in 199507b

#Modules/_ctypes/darwin/*.c

@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from 67d159c to 73b501e Compare December 27, 2022 19:30
@zware
Copy link
Member Author

zware commented Dec 27, 2022

Probably, this should be removed too:

Ah, thanks; I missed that one here, though I got the neighboring one in GH-100543.

@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from 73b501e to b2b2802 Compare December 28, 2022 19:37
@zware
pythongh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim
2404f50 
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from b2b2802 to 2404f50 Compare December 28, 2022 19:41
ronaldoussoren
ronaldoussoren approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@zware zware merged commit 2df82db into python:main Dec 29, 2022
@zware zware deleted the remove__ctypes_dlfcn_shim branch December 29, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees

@zware zware

Labels
3.12 bugs and security fixes build The build process and cross-build extension-modules C modules in the Modules dir OS-mac topic-ctypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zware @bedevere-bot @arhadthedev @ronaldoussoren