Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100321: Remove redundant variable newfree in function analyze_block #100327

Closed
wants to merge 1 commit into from
Closed

gh-100321: Remove redundant variable newfree in function analyze_block #100327

wants to merge 1 commit into from

Conversation

zikcheng
Copy link
Contributor

@zikcheng zikcheng commented Dec 18, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Dec 18, 2022
Closed
JosephSBoyle
JosephSBoyle reviewed Dec 18, 2022
View reviewed changes
Copy link
Contributor

@JosephSBoyle JosephSBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
What do the "newfree" and "allfree" vars represent?

@zikcheng
Copy link
Contributor Author

Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree.

@JosephSBoyle
Copy link
Contributor

@zikcheng Thanks for clarifying for me:)

@encukou
Copy link
Member

encukou commented Apr 10, 2024

In #101441, the allfree variable was removed instead.

Sorry that we missed this PR!

@encukou encukou closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephSBoyle JosephSBoyle JosephSBoyle left review comments

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zikcheng @JosephSBoyle @encukou @bedevere-bot @kumaraditya303