-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite3 bigmem test catches wrong exception #99659
Labels
Comments
Confirmed the same result on Linux (SQLite version 3.37.2). |
ambv
added a commit
to ambv/cpython
that referenced
this issue
Nov 21, 2022
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner.
ambv
added a commit
to ambv/cpython
that referenced
this issue
Nov 21, 2022
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner.
ambv
added a commit
that referenced
this issue
Nov 21, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 21, 2022
…nGH-99660) The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner. (cherry picked from commit 2781ec9) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington
added a commit
that referenced
this issue
Nov 22, 2022
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner. (cherry picked from commit 2781ec9) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Thanks for fixing these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lib/test/test_sqlite3/test_types.py
has two bigmem tests:test_too_large_string
; andtest_too_large_blob
.Those are skipped unless
-M
is passed to the test runner so nobody was running those tests until I set up a bigmem buildbot. Running tests on the buildbot revealed two failures:The
with self.assertRaises()
in those tests should catchsqlite.DataError
instead of the exceptions currently listed.Linked PRs
The text was updated successfully, but these errors were encountered: