Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys._git is empty on Windows #98629

Closed
zooba opened this issue Oct 25, 2022 · 1 comment
Closed

sys._git is empty on Windows #98629

zooba opened this issue Oct 25, 2022 · 1 comment
Assignees
@zooba
Labels
3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build OS-windows

Comments

@zooba
Copy link
Member

zooba commented Oct 25, 2022 •
edited by bedevere-bot
Loading

Compare/contrast these two official releases:

C:\> python3.11
Python 3.11.0 (main, Oct 24 2022, 18:26:48) [MSC v.1933 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys._git
('CPython', '', '')
>>> ^Z

C:\> python3.10
Python 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:50:30) [MSC v.1933 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys._git
('CPython', 'tags/v3.10.8', 'aaaf517')
>>> ^Z

Something broke in the build to not capture git information correctly.

Linked PRs
@zooba zooba added OS-windows build The build process and cross-build 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes labels Oct 25, 2022
@zooba zooba self-assigned this Oct 25, 2022
@zooba
Copy link
Member Author

zooba commented Oct 25, 2022

Looking at the build logs, the git commands captured the information correctly, so it's probably in the preprocessor substitutions.

zooba added a commit to zooba/cpython that referenced this issue Nov 21, 2022
@zooba
pythongh-98629: Fixes sys._git and sys.version creation on Windows
87cff62
@bedevere-bot bedevere-bot mentioned this issue Nov 21, 2022
Merged
zooba added a commit that referenced this issue Nov 21, 2022
@zooba
gh-98629: Fixes sys._git and sys.version creation on Windows (GH-99664)
49e554d
@bedevere-bot bedevere-bot mentioned this issue Nov 21, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 21, 2022
@zooba @miss-islington
pythongh-98629: Fixes sys._git and sys.version creation on Windows (p…
84b2af4 
…ythonGH-99664)

(cherry picked from commit 49e554d)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba closed this as completed Nov 21, 2022
miss-islington added a commit that referenced this issue Nov 21, 2022
@miss-islington @zooba
gh-98629: Fixes sys._git and sys.version creation on Windows (GH-99664)
2d5f4ba 
(cherry picked from commit 49e554d)

Co-authored-by: Steve Dower <steve.dower@python.org>
@picnixz picnixz removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zooba @picnixz