Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyObject_DelItemString is not documented #127954

Closed
koyuki7w opened this issue Dec 15, 2024 · 6 comments · Fixed by #127986
Closed

PyObject_DelItemString is not documented #127954

koyuki7w opened this issue Dec 15, 2024 · 6 comments · Fixed by #127986
Labels
docs Documentation in the Doc dir easy topic-C-API

Comments

@koyuki7w
Copy link
Contributor

koyuki7w commented Dec 15, 2024

Documentation

PyObject_DelItemString is part of the limited C-API and is undocumented. This function was implemented in commit b0d71d0 , but no documentation was added.

Linked PRs

@koyuki7w koyuki7w added the docs Documentation in the Doc dir label Dec 15, 2024
@ZeroIntensity
Copy link
Member

Thanks for tracking these down. You might also want to take a look at gh-118915 if you're interested in submitting some PRs :)

@picnixz
Copy link
Member

picnixz commented Dec 15, 2024

For anyone interested in documenting this one: it's the same as PyObject_DelItem but instead of taking the key as a PyObject *, it takes the key as a const char *. We should just mention that the key is a UTF-8 encoded bytes string (see PyObject_HasAttrStringWithError for instance for a similar formulation when the parameter is a const char *).

@rruuaanng
Copy link
Contributor

I want to ask, if I can complete it? It's documentation can be like at PyObject_HasAttrStringWithError :---)

@picnixz
Copy link
Member

picnixz commented Dec 15, 2024

I'd wait a week in case @koyuki7w wanted to take it (they've be contributing to docs recently).

@koyuki7w
Copy link
Contributor Author

koyuki7w commented Dec 16, 2024

@rruuaanng Yes, please complete and open PR.

@erlend-aasland erlend-aasland linked a pull request Jan 4, 2025 that will close this issue
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 4, 2025
(cherry picked from commit 8ade153)

Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 4, 2025
(cherry picked from commit 8ade153)

Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
@erlend-aasland
Copy link
Contributor

Thanks for the report, Yuki; thanks for the PR, James.

Documentation added in…:

Auto-merge enabled for the backports. Marking as resolved.

erlend-aasland pushed a commit that referenced this issue Jan 4, 2025
(cherry picked from commit 8ade153)

Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
erlend-aasland pushed a commit that referenced this issue Jan 4, 2025
(cherry picked from commit 8ade153)

Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir easy topic-C-API
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

5 participants