Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__del__ documentation does not mention weakref #120937

Closed
chaen opened this issue Jun 24, 2024 · 0 comments
Closed

__del__ documentation does not mention weakref #120937

chaen opened this issue Jun 24, 2024 · 0 comments
Labels
docs Documentation in the Doc dir

Comments

@chaen
Copy link
Contributor

chaen commented Jun 24, 2024 •
edited by bedevere-app bot
Loading

Documentation

the weakref documentation mentions __del__ and compares with it. However, __del__ documentation does not mention weakref, while this is most probably what the vast majority or developers is looking for feature wise.

https://docs.python.org/3/library/weakref.html#comparing-finalizers-with-del-methods

Linked PRs
@chaen chaen added the docs Documentation in the Doc dir label Jun 24, 2024
chaen added a commit to chaen/cpython that referenced this issue Jun 24, 2024
@chaen
pythongh-120937: Reference weakref from the __del__ documentation
ffafa4d 
The weakref documentation refers to __del__, but not
the other way around.
@chaen chaen mentioned this issue Jun 24, 2024
Merged
sobolevn pushed a commit that referenced this issue Jun 26, 2024
@chaen @hugovk
gh-120937: Reference weakref from the __del__ documentation (#120940)
1c13b29 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 26, 2024
@chaen @hugovk @miss-islington
pythongh-120937: Reference weakref from the __del__ documentation (p…
1950dd4 
…ythonGH-120940)

(cherry picked from commit 1c13b29)

Co-authored-by: chaen <christophe.haen@cern.ch>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 26, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 26, 2024
@chaen @hugovk @miss-islington
pythongh-120937: Reference weakref from the __del__ documentation (p…
bc7c48c 
…ythonGH-120940)

(cherry picked from commit 1c13b29)

Co-authored-by: chaen <christophe.haen@cern.ch>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 26, 2024
Merged
sobolevn pushed a commit that referenced this issue Jun 26, 2024
@miss-islington @chaen @hugovk
[3.12] gh-120937: Reference weakref from the __del__ documentation (G…
709ef00 
…H-120940) (#121062)

gh-120937: Reference weakref from the `__del__` documentation (GH-120940)
(cherry picked from commit 1c13b29)

Co-authored-by: chaen <christophe.haen@cern.ch>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
sobolevn pushed a commit that referenced this issue Jun 26, 2024
@miss-islington @chaen @hugovk
[3.13] gh-120937: Reference weakref from the __del__ documentation (G…
d7cd71c 
…H-120940) (#121061)

gh-120937: Reference weakref from the `__del__` documentation (GH-120940)
(cherry picked from commit 1c13b29)

Co-authored-by: chaen <christophe.haen@cern.ch>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@chaen @hugovk @mrahtz
pythongh-120937: Reference weakref from the __del__ documentation (p…
1c991d4 
…ython#120940)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@chaen @hugovk @noahbkim
pythongh-120937: Reference weakref from the __del__ documentation (p…
31df1f1 
…ython#120940)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@chaen @hugovk @estyxx
pythongh-120937: Reference weakref from the __del__ documentation (p…
af9b173 
…ython#120940)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaen @sobolevn