Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up pathlib by removing a few temporary objects #112361

Closed
barneygale opened this issue Nov 24, 2023 · 0 comments
Closed

Speed up pathlib by removing a few temporary objects #112361

barneygale opened this issue Nov 24, 2023 · 0 comments
Labels
performance Performance or resource usage topic-pathlib

Comments

@barneygale
Copy link
Contributor

barneygale commented Nov 24, 2023 •
edited by bedevere-app bot
Loading

A handful of pathlib methods that create paths with modified names, or additional segments, use list objects that are quickly thrown away. We can speed these methods up by only creating new lists where strictly necessary.

Specifically:

  • with_name() (performance of self._tail[:-1] + [name] is cursed)
  • with_suffix()
  • _make_child_relpath() (used in glob() and walk())
  • glob() (when parsing the pattern)

Linked PRs
@barneygale barneygale added performance Performance or resource usage topic-pathlib labels Nov 24, 2023
barneygale added a commit to barneygale/cpython that referenced this issue Nov 24, 2023
@barneygale
pythonGH-112361: Speed up pathlib by removing some temporary objects.
12e2551 
Construct only one new list object (using `list.copy()`) when creating a
new path object with a modified tail. This slightly speeds up
`with_name()`, `with_suffix()`, `_make_child_relpath()` (used in walking
and globbing), and `glob()`.
@bedevere-app bedevere-app bot mentioned this issue Nov 24, 2023
Merged
barneygale added a commit that referenced this issue Nov 25, 2023
@barneygale
GH-112361: Speed up pathlib by removing some temporary objects. (#112362
19a1fc1 
)

Construct only one new list object (using `list.copy()`) when creating a
new path object with a modified tail. This slightly speeds up
`with_name()` and `with_suffix()`
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@barneygale @aisk
pythonGH-112361: Speed up pathlib by removing some temporary objects. (…
7563b4c 
…python#112362)

Construct only one new list object (using `list.copy()`) when creating a
new path object with a modified tail. This slightly speeds up
`with_name()` and `with_suffix()`
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@barneygale @Glyphack
pythonGH-112361: Speed up pathlib by removing some temporary objects. (…
b3e372b 
…python#112362)

Construct only one new list object (using `list.copy()`) when creating a
new path object with a modified tail. This slightly speeds up
`with_name()` and `with_suffix()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage topic-pathlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneygale