Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python/importlib.h #103326

Closed
brettcannon opened this issue Apr 7, 2023 · 0 comments
Closed

Remove Python/importlib.h #103326

brettcannon opened this issue Apr 7, 2023 · 0 comments
Labels
3.12 bugs and security fixes easy type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Apr 7, 2023 •
edited by bedevere-bot
Loading

https://github.com/python/cpython/blob/main/Python/importlib.h doesn't seem to be used anymore. I think it can simply be deleted and then a quick search through the code base to remove any references (it's mentioned in some comments).

Linked PRs
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error easy 3.12 bugs and security fixes labels Apr 7, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 7, 2023
@sobolevn
pythongh-103326: Remove Python/importlib.h
13f5f05
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 7, 2023
@sobolevn
pythongh-103326: Remove Python/importlib.h
f92bb1f
@bedevere-bot bedevere-bot mentioned this issue Apr 7, 2023
Merged
brettcannon added a commit that referenced this issue Apr 12, 2023
@sobolevn @brettcannon @hugovk
gh-103326: Remove Python/importlib.h (GH-103331)
7f3c106 
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this issue Apr 18, 2023
@sobolevn @brettcannon
@hugovk @aisk
pythongh-103326: Remove Python/importlib.h (pythonGH-103331)
8692fd0 
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes easy type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon