Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure should conditionally add -fno-reorder-blocks-and-partition #101060

Closed
indygreg opened this issue Jan 15, 2023 · 2 comments
Closed

Configure should conditionally add -fno-reorder-blocks-and-partition #101060

indygreg opened this issue Jan 15, 2023 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@indygreg
Copy link
Contributor

indygreg commented Jan 15, 2023 •
edited by bedevere-bot
Loading

Bug report

--enable-bolt currently unconditionally adds -fno-reorder-blocks-and-partition. This flag isn't implemented on Clang and breaks the build in this configuration.

PR forthcoming.

Linked PRs
@indygreg indygreg added the type-bug An unexpected behavior, bug, or error label Jan 15, 2023
indygreg added a commit to indygreg/cpython that referenced this issue Jan 15, 2023
@indygreg
pythongh-101060: conditionally add -fno-reorder-blocks-and-partition
a076b71 
The flag isn't implemented on Clang. So we need this so we can
enable BOLT on Clang.
@bedevere-bot bedevere-bot mentioned this issue Jan 15, 2023
Merged
indygreg added a commit to indygreg/cpython that referenced this issue Jan 15, 2023
@indygreg
pythongh-101060: conditionally add -fno-reorder-blocks-and-partition
e267855 
The flag isn't implemented on Clang. So we need this so we can
enable BOLT on Clang.
indygreg added a commit to indygreg/cpython that referenced this issue Jan 16, 2023
@indygreg
pythongh-101060: conditionally add -fno-reorder-blocks-and-partition
41ee2c9 
The flag isn't implemented on Clang. So we need this so we can
enable BOLT on Clang.
indygreg added a commit to indygreg/cpython that referenced this issue Jan 21, 2023
@indygreg
pythongh-101060: conditionally add -fno-reorder-blocks-and-partition
c2a7c2a 
The flag isn't implemented on Clang. So we need this so we can
enable BOLT on Clang.
@corona10
Copy link
Member

Current status


clangclangclangclangclang: : : : : clangerror: error: : error: clangerror: error: unknown argument: '-fno-reorder-blocks-and-partition'clangunknown argument: '-fno-reorder-blocks-and-partition'unknown argument: '-fno-reorder-blocks-and-partition'unknown argument: '-fno-reorder-blocks-and-partition'

unknown argument: '-fno-reorder-blocks-and-partition'error:

: unknown argument: '-fno-reorder-blocks-and-partition'error: unknown argument: '-fno-reorder-blocks-and-partition'
: error:
unknown argument: '-fno-reorder-blocks-and-partition'

corona10 pushed a commit that referenced this issue Jan 24, 2023
@indygreg
gh-101060: conditionally add -fno-reorder-blocks-and-partition (gh-…
7589d71 
…101061)
@corona10
Copy link
Member

Now BOLT build supports clang too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indygreg @corona10