Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LIBTOOL_CRUFT from configure #101047

Closed
indygreg opened this issue Jan 14, 2023 · 1 comment
Closed

Remove LIBTOOL_CRUFT from configure #101047

indygreg opened this issue Jan 14, 2023 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@indygreg
Copy link
Contributor

indygreg commented Jan 14, 2023 •
edited by bedevere-bot
Loading

Feature or enhancement

Per summary.

Linked PRs
@indygreg indygreg added the type-feature A feature request or enhancement label Jan 14, 2023
indygreg added a commit to indygreg/cpython that referenced this issue Jan 14, 2023
@indygreg
pythongh-101047: Remove LIBTOOL_CRUFT
ab9ca85 
This variable has been unused since commit
1919983 in 2011.

I noticed it because the `arch` logic breaks when cross-compiling on
macOS.
@bedevere-bot bedevere-bot mentioned this issue Jan 14, 2023
Merged
indygreg added a commit to indygreg/cpython that referenced this issue Jan 15, 2023
@indygreg
pythongh-101047: Remove LIBTOOL_CRUFT
a1016d2 
This variable has been unused since commit
1919983 in 2011.

I noticed it because the `arch` logic breaks when cross-compiling on
macOS.
indygreg added a commit to indygreg/cpython that referenced this issue Jan 15, 2023
@indygreg
pythongh-101047: Remove LIBTOOL_CRUFT
dae8974 
This variable has been unused since commit
1919983 in 2011.

I noticed it because the `arch` logic breaks when cross-compiling on
macOS.

skip news since effectively dead code.
indygreg added a commit to indygreg/cpython that referenced this issue Jan 21, 2023
@indygreg
pythongh-101047: Remove LIBTOOL_CRUFT and OTHER_LIBTOOL_OPT
44d2741 
Both variables have been unused since commit
1919983 in 2011.

I noticed it because the `arch` logic breaks when cross-compiling on
macOS.

skip news since effectively dead code.
ned-deily pushed a commit that referenced this issue Jan 22, 2023
@indygreg
gh-101047: Remove vestigial references to macOS libtool options (gh-1…
79af40a 
…01048)

LIBTOOL_CRUFT and OTHER_LIBTOOL_OPT variables have been unused since commit
1919983 in 2011.
@ned-deily
Copy link
Member

Thanks for the PR and the updates. Merged for release in 3.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indygreg @ned-deily