Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize types module usage in copy module #100815

Closed
sobolevn opened this issue Jan 7, 2023 · 0 comments
Closed

Normalize types module usage in copy module #100815

sobolevn opened this issue Jan 7, 2023 · 0 comments
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 7, 2023

Right now there are two minor problems with it:

  1. Here CodeType is assumed to be missing for some reason:
    t = getattr(types, "CodeType", None)
    But here, it is just used as it should be:
    d[types.CodeType] = _deepcopy_atomic
  2. We can also modernize type(None) and etc to use existing types. aliases for clarity

Linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants