Skip to content

Commit

Permalink
gh-122136: test_asyncio: Don't fail if the kernel buffers more data t…
Browse files Browse the repository at this point in the history
…han advertised (GH-123423)
  • Loading branch information
encukou authored Aug 28, 2024
1 parent 61bef62 commit b379f1b
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions Lib/test/test_asyncio/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ async def serve(rd, wr):

(s_rd, s_wr) = await fut

# Limit the socket buffers so we can reliably overfill them
# Limit the socket buffers so we can more reliably overfill them
s_sock = s_wr.get_extra_info('socket')
s_sock.setsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF, 65536)
c_sock = c_wr.get_extra_info('socket')
Expand All @@ -242,10 +242,18 @@ async def serve(rd, wr):
await asyncio.sleep(0)

# Get the writer in a waiting state by sending data until the
# socket buffers are full on both server and client sockets and
# the kernel stops accepting more data
s_wr.write(b'a' * c_sock.getsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF))
s_wr.write(b'a' * s_sock.getsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF))
# kernel stops accepting more data in the send buffer.
# gh-122136: getsockopt() does not reliably report the buffer size
# available for message content.
# We loop until we start filling up the asyncio buffer.
# To avoid an infinite loop we cap at 10 times the expected value
c_bufsize = c_sock.getsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF)
s_bufsize = s_sock.getsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF)
for i in range(10):
s_wr.write(b'a' * c_bufsize)
s_wr.write(b'a' * s_bufsize)
if s_wr.transport.get_write_buffer_size() > 0:
break
self.assertNotEqual(s_wr.transport.get_write_buffer_size(), 0)

task = asyncio.create_task(srv.wait_closed())
Expand Down

0 comments on commit b379f1b

Please sign in to comment.