Skip to content

Commit

Permalink
bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777)
Browse files Browse the repository at this point in the history
Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith <chris@cdgriffith.com>
  • Loading branch information
miss-islington and cdgriffith authored Mar 12, 2021
1 parent 531f2eb commit ad83fde
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Lib/subprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -1525,10 +1525,8 @@ def _communicate(self, input, endtime, orig_timeout):
self.stderr.close()

# All data exchanged. Translate lists into strings.
if stdout is not None:
stdout = stdout[0]
if stderr is not None:
stderr = stderr[0]
stdout = stdout[0] if stdout else None
stderr = stderr[0] if stderr else None

return (stdout, stderr)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:func:`subprocess.communicate` no longer raises an IndexError when there is an
empty stdout or stderr IO buffer during a timeout on Windows.

0 comments on commit ad83fde

Please sign in to comment.