Restructure as per review comment

python · Jun 23, 2024 · 6daf85e · 6daf85e
1 parent ccc0060
commit 6daf85e
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/Lib/logging/config.py b/Lib/logging/config.py
@@ -804,8 +804,15 @@ def configure_handler(self, config):
                             # if it's not an instance of BaseProxy, it also can't be
                             # an instance of Manager.Queue / Manager.JoinableQueue
                             if isinstance(qspec, BaseProxy):
-                                proxy_queue = MM().Queue()
-                                proxy_joinable_queue = MM().JoinableQueue()
+                                # Sometimes manager or queue creation might fail
+                                # (e.g. see issue gh-120868). In that case, any
+                                # exception during the creation of these queues will
+                                # propagate up to the caller and be wrapped in a
+                                # `ValueError`, whose cause will indicate the details of
+                                # the failure.
+                                mm = MM()
+                                proxy_queue = mm.Queue()
+                                proxy_joinable_queue = mm.JoinableQueue()
                                 if not isinstance(qspec, (type(proxy_queue), type(proxy_joinable_queue))):
                                     raise TypeError('Invalid queue specifier %r' % qspec)
                             else: