Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tier in buildbot failure message #583

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 1, 2025

Fixes #582.

I don't have a good way of testing this, I did so by putting this at the end of builders.py and ran make check:

print(get_builder_tier("AMD64 Fedora Stable LTO + PGO"))
print(get_builder_tier("AMD64 Fedora Stable Clang Installed 3.x"))
print(get_builder_tier("aarch64 Fedora Stable Clang Installed 3.x"))
print(get_builder_tier("aarch64 Fedora Stable Clang Installed 3.11"))
print(get_builder_tier("aarch64 Fedora Stable Clang Installed 3.9"))
print(get_builder_tier("aarch64 RHEL8 LTO 3.13"))
print(get_builder_tier("AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x"))
print(get_builder_tier("PPC64LE Fedora Rawhide Clang Installed 3.x"))

And got:

tier-1
tier-2
tier-2
tier-2
tier-2
tier-2
no tier
tier-3

Comment on lines +340 to +347
(STABLE_BUILDERS_TIER_1, TIER_1),
(STABLE_BUILDERS_TIER_2,TIER_2),
(STABLE_BUILDERS_TIER_3, TIER_3),
(STABLE_BUILDERS_NO_TIER, NO_TIER),
(UNSTABLE_BUILDERS_TIER_1, TIER_1),
(UNSTABLE_BUILDERS_TIER_2, TIER_2),
(UNSTABLE_BUILDERS_TIER_3, TIER_3),
(UNSTABLE_BUILDERS_NO_TIER, NO_TIER),
Copy link
Member

@picnixz picnixz Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a data structure holding those? like STABLE_TIER_LIST = {TIER_1: STABLE_BUILDERS_TIER_1, ... and UNSTABLE_TIER_LIST = {...}?

@ambv ambv merged commit 6ab531a into python:main Mar 1, 2025
1 check passed
@hugovk hugovk deleted the show-tier-in-failure-warning branch March 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate the buildbot tier when reporting failures upon merges
3 participants