Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache configuration #577

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Add cache configuration #577

merged 2 commits into from
Feb 20, 2025

Conversation

zware
Copy link
Member

@zware zware commented Feb 16, 2025

These are mostly made up numbers just to see if there is any noticeable effect on either performance or memory usage.

@@ -110,6 +110,17 @@ c["configurators"] = [
)
]

c["caches"] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment explaining how you chose these numbers?

I'm fine with "These are mostly made up numbers just to see if there is any noticeable effect on either performance or memory usage."

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware merged commit 62b177d into python:main Feb 20, 2025
1 check passed
@zware zware deleted the cache_config branch February 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants