Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for diegorusso-aarch64-bigmem #553

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fixes for diegorusso-aarch64-bigmem #553

merged 2 commits into from
Nov 6, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Nov 6, 2024 •
edited
Loading

Follow-up to #546

  • Get the current time when a build is requested, rather than when the config is first loaded
  • Return a Deferred from nextBuild. By my reading of the nextBuild and Deferred docs, this is the way to do it.

@encukou encukou requested review from diegorusso and zware November 6, 2024 09:06
@encukou encukou mentioned this pull request Nov 6, 2024
Merged
@encukou
Copy link
Member Author

encukou commented Nov 6, 2024

checkconfig & reconfig works.

@diegorusso
Copy link
Contributor

Thanks @encukou! The fixes make sense to me 👍🏽

@encukou encukou merged commit 2000750 into python:main Nov 6, 2024
1 check passed
@encukou encukou deleted the fix-diegorusso-aarch64-bigmem branch November 6, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegorusso diegorusso Awaiting requested review from diegorusso

@zware zware Awaiting requested review from zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @diegorusso