-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FedoraBuild for Fedora and RHEL #264
Conversation
"make" when installing Tempita in a venv:
See https://twitter.com/mitsuhiko/status/1435661088746577930 "Latest setuptools removes the ability to invoke 2to3 as part of the installation. With that Flask-OpenID broke which means that Airflow broke. I don't even have the energy to fix an ancient package at this point but apparently existing airflow installations are now screwed :-/" flask-openid fix to avoid 2to3: pallets-eco/flask-openid#60 |
For Tempita use_2to3 error, see: https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1943127 |
I also reported the issue to buildbot: buildbot/buildbot#6229 |
Test ./configure --with-platlibdir=lib64 on Fedora and RHEL, but also other configure flags used by the Fedora specfile, like --enable-shared and --with-system-expat.
I pushed a workaround: 73a70b5 |
master/custom/factories.py
Outdated
"--with-dbmliborder=gdbm:ndbm:bdb", | ||
"--with-system-expat", | ||
"--with-system-ffi", | ||
"--with-system-libmpdec", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding options like this means we need to pull in the devel packages. Also, IIRC we can only use system mpdec in 3.10+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devel packages are already in the buildbots
# https://src.fedoraproject.org/rpms/python3.10/blob/rawhide/f/python3.10.spec | ||
configureFlags = [ | ||
"--with-pydebug", | ||
"--with-platlibdir=lib64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only makes sense on 64bit arches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the Fedora and RHEL buildbots are 64 bits.
@hroncok @stratakis: I prefer to start easy, I disabled --with-system-expat, --with-system-ffi and --with-system-libmpdec. Let's see first how many buildbot workers are broken by this first incomplete change :-D Also, I created one configuration per OS version:
For now, RHEL7 and RHEL8 are the same, so are Fedora Stable and Fedora Rawhide. |
s390x RHEL8 3.10: configure failed: https://buildbot.python.org/all/#/builders/700/builds/341
PPC64LE RHEL7 3.10: https://buildbot.python.org/all/#/builders/619/builds/311 (same Valgrind error) s390x RHEL7 3.10: https://buildbot.python.org/all/#/builders/658/builds/351 (same Valgrind error) s390x Fedora 3.10: https://buildbot.python.org/all/#/builders/655/builds/338 (same Valgrind error) |
That is because Valgrind has:
https://src.fedoraproject.org/rpms/valgrind/blob/rawhide/f/valgrind.spec#_230 Fedora's Python has:
|
I rebuilt "s390x RHEL8 3.10" without the Valgrind flag and it went a little bit further until...
|
Test ./configure --with-platlibdir=lib64 on Fedora and RHEL, but also
other configure flags used by the Fedora specfile, like
--enable-shared and --with-system-expat.